Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API for system CVE allowlist to new model #14412

Merged
merged 1 commit into from
Mar 12, 2021

Conversation

reasonerjt
Copy link

Signed-off-by: Daniel Jiang jiangd@vmware.com

@codecov
Copy link

codecov bot commented Mar 11, 2021

Codecov Report

Merging #14412 (33384b5) into master (4ef9356) will decrease coverage by 0.01%.
The diff coverage is 28.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14412      +/-   ##
==========================================
- Coverage   64.61%   64.59%   -0.02%     
==========================================
  Files         919      920       +1     
  Lines       64997    65138     +141     
  Branches     2034     2034              
==========================================
+ Hits        41999    42079      +80     
- Misses      19042    19099      +57     
- Partials     3956     3960       +4     
Flag Coverage Δ
unittests 64.59% <28.57%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/common/models/base.go 100.00% <ø> (ø)
src/common/models/project.go 36.92% <ø> (ø)
src/pkg/allowlist/models/cve_allowlist.go 92.30% <ø> (ø)
src/pkg/allowlist/validator.go 90.00% <ø> (ø)
src/pkg/scan/report/summary.go 62.74% <ø> (ø)
src/pkg/scan/vuln/report.go 100.00% <ø> (ø)
src/server/v2.0/handler/handler.go 0.00% <0.00%> (ø)
src/server/v2.0/handler/model/cve_allowlist.go 0.00% <0.00%> (ø)
src/server/v2.0/handler/sys_cve_allowlist.go 0.00% <0.00%> (ø)
src/controller/project/controller.go 37.83% <20.00%> (ø)
... and 16 more

Signed-off-by: Daniel Jiang <jiangd@vmware.com>
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants